geyser: add flag geyser-plugin-snapshot-disabled
#4103
Conversation
fanatid
force-pushed
the
geyser-snapshot-disable-flag
branch
from
194a7d3 to
d48cdb9
Compare
fanatid
force-pushed
the
geyser-snapshot-disable-flag
branch
from
d48cdb9 to
4c23162
Compare
fanatid
force-pushed
the
geyser-snapshot-disable-flag
branch
from
4c23162 to
526eef9
Compare
|
|
||
| slots.sort_by(|a, b| b.cmp(a)); | ||
| for slot in slots { | ||
| self.notify_accounts_in_slot(slot, &mut notified_accounts, &mut notify_stats); |
There was a problem hiding this comment.
Do you know why this code take minutes?
There was a problem hiding this comment.
because of amount of data -- could be 100 millions of records
|
Granted nobody ever reviewed this PR, but this is looking to accomplish the same thing that #2022 does right ? |
|
@steviez oh wow, I remember that PR and my PR doing the same just in different way! Actually, I think that #2022 way to define snapshot requirement through an additional method looks much better than the flag. @steviez @lijunwangs what do you think, if:
|
fanatid
force-pushed
the
geyser-snapshot-disable-flag
branch
2 times, most recently
from
3d5b2c5 to
7acf15c
Compare
fanatid
force-pushed
the
geyser-snapshot-disable-flag
branch
from
7acf15c to
b7801ee
Compare
|
Updated from CLI argument to Geyser interface function |
That sounds okay -- so we allow the plugin to opt in. |
Co-authored-by: Lijun Wang <[email protected]>
|
@lijunwangs thank you! is it possible to create a backport to v2.1? |
Problem
Startup time with an enabled geyser interface is significant and CPU load does not exceed 100%. Disable snapshot on nodes that need geyser but do not need snapshot reduce startup time on 15-20min.
Summary of Changes
PR introduces a new flag
--geyser-plugin-snapshot-disabled, if flag is set then account notifications from snapshot to geyser are ignored and the node starts faster while geyser interface is still enabled.