Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixup flaky OC test #4119

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fixup flaky OC test #4119

wants to merge 1 commit into from

Conversation

carllin
Copy link

@carllin carllin commented Dec 15, 2024

Problem

Removing the tower caused the validator to panic when restarting and revoting on a slot they had already voted on before the restart

Summary of Changes

  1. Restart validator with no-voting flag, wait for him to make his leader slot X on the parent of the OC slot that we want to roll back, check it lands in ledger
  2. Restart validator with the voting flag
  3. Because the slot X is new, he won't have voted on it, so will avoid the gossip panic

Fixes #4060

@carllin carllin requested a review from AshwinSekar December 15, 2024 01:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Investigate and fix flakiness of local-cluster optimistic confirmation tests
2 participants