Define SchedulerInner for fine-grained cleaning #4133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
ryoqun
commented
Dec 16, 2024
| fn return_scheduler(&self, scheduler: S::Inner) { | ||
| // Refer to the comment in is_aborted() as to the exact definition of the concept of | ||
| // _trashed_ and the interaction among different parts of unified scheduler. | ||
| let should_trash = scheduler.is_trashed(); |
There was a problem hiding this comment.
Now that S::Inner is bound to SchedulerInner, .is_trashed() is callable in this context, so remove the unneeded arg (should_trash).
apfitzge
approved these changes
Dec 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
solScCleanerwill need to access more inner workings of SchedulerInner for block production.Summary of Changes
Introduce such an trait in advance.
No functional change, so no test is added.
extracted from #3946, see the pr for the general overview.