Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix hanging bench_sigverify_stage_with_same_tx #4141

Merged
merged 1 commit into from
Dec 16, 2024
Merged

Fix hanging bench_sigverify_stage_with_same_tx #4141

merged 1 commit into from
Dec 16, 2024

Conversation

apfitzge
Copy link

Problem

Summary of Changes

  • Fix exit condition for use_same_packet variant of bench

Fixes #

@apfitzge apfitzge requested a review from bw-solana December 16, 2024 13:33
@apfitzge
Copy link
Author

Verified that before #4043 and after this patch, the benches have same approximate times reported.

bw-solana
bw-solana approved these changes Dec 16, 2024
View reviewed changes
Copy link

@bw-solana bw-solana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@apfitzge apfitzge merged commit e84db7f into anza-xyz:master Dec 16, 2024
40 checks passed
@apfitzge apfitzge deleted the fix_hanging_bench branch December 16, 2024 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bw-solana bw-solana bw-solana approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@apfitzge @bw-solana