optional prioritization_fee_cache #4144
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apfitzge
changed the title
apfitzge
commented
Dec 16, 2024
| @@ -1107,7 +1110,7 @@ impl Validator { | |||
| connection_cache.clone(), | |||
| max_complete_transaction_status_slot, | |||
| max_complete_rewards_slot, | |||
| prioritization_fee_cache.clone(), | |||
| prioritization_fee_cache.clone().unwrap(), | |||
There was a problem hiding this comment.
I think ideally, we would not have to unwrap here.
prioritization_fee_cache can/should be initialized in the same if statement...however it involves re-ordering a lot of stuff so that RPC is spawned earlier on.
Thinking it's simpler for this PR to just unwrap, and a follow-up PR for re-ordering initializaton in validator.rs?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
#4142
Summary of Changes
Fixes #