removes intermediate vector allocations in ClusterNodes::get_retransmit_addrs #4146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
behzadnouri
changed the title
behzadnouri
force-pushed
the
get-retransmit-peers-rm-collect
branch
3 times, most recently
from
b671371 to
ecc3f0f
Compare
…it_addrs ClusterNodes::get_retransmit_addrs does 2 intermediate collects: https://github.com/anza-xyz/agave/blob/3890ce5bc/turbine/src/cluster_nodes.rs#L222 https://github.com/anza-xyz/agave/blob/3890ce5bc/turbine/src/cluster_nodes.rs#L239 The commit avoids both by chaining iterator operations.
behzadnouri
force-pushed
the
get-retransmit-peers-rm-collect
branch
from
ecc3f0f to
e6f1b71
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
ClusterNodes::get_retransmit_addrsdoes 2 intermediate.collect::<Vec<_>>:https://github.com/anza-xyz/agave/blob/3890ce5bc/turbine/src/cluster_nodes.rs#L222
https://github.com/anza-xyz/agave/blob/3890ce5bc/turbine/src/cluster_nodes.rs#L239
Summary of Changes
The commit avoids both by chaining iterator operations.