Switch build_tpu_quic_client to actually connect to the given validator #4151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AshwinSekar
reviewed
Dec 17, 2024
gregcusack
reviewed
Dec 17, 2024
local-cluster/src/cluster.rs
Outdated
Comment on lines
49
to
50
| fn build_entrypoint_tpu_quic_client(&self) -> Result<QuicTpuClient>; | ||
| fn build_entrypoint_tpu_quic_client_with_commitment( |
There was a problem hiding this comment.
do we need these two if we can just pass in the pubkey of the entrypoint? we always know entrypoint pubkey since it is s public member of LocalCluster
There was a problem hiding this comment.
haha yeah i didn't have these two at first, but a bunch of call sites were using the original default method, so figured might as well expose a convenient way to do this.
Removed the two unnecessary methods
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Current
fn get_validator_client(&self, pubkey: &Pubkey) -> Option<QuicTpuClient>;inlocal-cluster/src/cluster.rsalways builds a client connected to the entrypoint validator, even if a different validator is specifiedSummary of Changes
Grab the correct
ContactInfofrom the cluster and conenct to the correct valdiatorFixes #