sdk: evict rent collector #4160
Conversation
buffalojoec
force-pushed
the
sdk-evict-rent-collector
branch
from
3d3dbec to
951c8c7
Compare
buffalojoec
force-pushed
the
sdk-evict-rent-collector
branch
3 times, most recently
from
5574dec to
c137850
Compare
buffalojoec
force-pushed
the
sdk-evict-rent-collector
branch
from
c137850 to
76be235
Compare
| extern crate log as logger; | ||
| #[cfg_attr(not(target_os = "solana"), macro_use)] | ||
| extern crate serde_derive; | ||
|
|
||
| #[cfg_attr(feature = "frozen-abi", macro_use)] | ||
| #[cfg(feature = "frozen-abi")] | ||
| extern crate solana_frozen_abi_macro; |
There was a problem hiding this comment.
We can probably remove all of these, but it seems unrelated to this PR -- can you split it out into another PR?
There was a problem hiding this comment.
It was a clippy error, but sure.
There was a problem hiding this comment.
It will not pass CI here if it's not part of this PR, though.
There was a problem hiding this comment.
Ooh, this is actually beautiful! This is the last module still using frozen-abi and serde-derive, we can remove frozen-abi and move serde-derive to dev-deps. I can put that change in once yours goes in.
| @@ -22,7 +22,7 @@ pub mod tests { | |||
|
|
|||
| #[test] | |||
| fn test_limited_deserialize() { | |||
| #[derive(Deserialize, Serialize)] | |||
| #[derive(serde_derive::Deserialize, serde_derive::Serialize)] | |||
There was a problem hiding this comment.
Same with this, unless I'm missing something, it should get split out into another PR.
Co-authored-by: Jon C <[email protected]>
| extern crate log as logger; | ||
| #[cfg_attr(not(target_os = "solana"), macro_use)] | ||
| extern crate serde_derive; | ||
|
|
||
| #[cfg_attr(feature = "frozen-abi", macro_use)] | ||
| #[cfg(feature = "frozen-abi")] | ||
| extern crate solana_frozen_abi_macro; |
There was a problem hiding this comment.
Ooh, this is actually beautiful! This is the last module still using frozen-abi and serde-derive, we can remove frozen-abi and move serde-derive to dev-deps. I can put that change in once yours goes in.
Completes the work for #3932 and finally evicts
RentCollectorfrom the SDK.