v2.0: Fixes clean_old_storages_with_reclaims tests (backport of #4147) #4166
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The two accounts-db
clean_old_storages_with_reclaims
tests incorrectly set up the dirty stores/uncleaned pubkeys to test out the desiredclean
situations. This is becauseuncleaned_roots
is used, but this struct is not responsible for deciding which slots to load as clean candidates.Summary of Changes
Fixes the tests to not use uncleaned_roots.
Justification to Backport
We added (and backported) code and tests for fixing some accounts-db
clean
issues. There seems to still be an accounts-db clean issue that RPC nodes have been hitting. If we find, fix, and backport that issue, I'd like to have the current clean tests be correct. This backport PR fixes those tests.This is an automatic backport of pull request #4147 done by [Mergify](https://mergify.com).