Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bench-streamer: Fix argument parsing #4168

Merged
merged 1 commit into from
Dec 18, 2024

Conversation

steviez
Copy link

@steviez steviez commented Dec 18, 2024

Problem

The value to parse is declared as num-producers but the code is currently parsing num_producers. So, this value cannot actually be changed as is

@steviez steviez changed the title fix: argument parsing in bench-streamer bench-streamer: Fix argument parsing Dec 18, 2024
The value to parse is declared as num-producers but the code is
currently parsing num_producers. So, this value cannot actually be
changed as is
@steviez steviez force-pushed the bench_streamer_arg_broken branch from 2a5b51b to 017ac92 Compare December 18, 2024 19:29
Copy link

@gregcusack gregcusack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@steviez steviez merged commit 7fc3fbb into anza-xyz:master Dec 18, 2024
40 checks passed
@steviez steviez deleted the bench_streamer_arg_broken branch December 18, 2024 22:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants