uses ahash::RandomState::hash_one in deduper::Deduper #4184
+3
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahash::RandomState has specializations for hashing single value, which can be faster for primitive types: https://github.com/tkaitchuck/aHash/blob/7d5c661a7/src/random_state.rs#L317 https://github.com/tkaitchuck/aHash/blob/7d5c661a7/src/specialize.rs#L17-L19
gregcusack
approved these changes
Jan 3, 2025
There was a problem hiding this comment.
lgtm! only concern i had initially was hashing: &(key, i) here:
(0..max_duplicate_count).all(|i| self.shred_id_filter.dedup(&(key, i)))
but if i'm reading this right, key is of type ShredId and ShredId is just three primitive types under the hood. so should be good!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
ahash::RandomStatehas specializations for hashing single value, which can be faster for primitive types:https://github.com/tkaitchuck/aHash/blob/7d5c661a7/src/random_state.rs#L317
https://github.com/tkaitchuck/aHash/blob/7d5c661a7/src/specialize.rs#L17-L19
Summary of Changes
The commit uses
ahash::RandomState::hash_oneindeduper::Deduper.