dedups shreds by common-header instead of the entire payload #4187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
behzadnouri
requested review from
AshwinSekar
and removed request for
AshwinSekar
behzadnouri
changed the title
behzadnouri
force-pushed
the
shred-dedup-common-header
branch
from
6686e09 to
c0f556d
Compare
Shreds in the retransmit stage:
* don't have repair nonce (repaired shreds are not retransmitted).
* are already resigned by this node as the retransmitter.
* have their leader's signature verified.
Therefore in order to dedup shreds, it suffices to compare:
(signature, slot, shred-index, shred-type)
Because ShredCommonHeader already includes all of the above tuple,
the rest of the payload can be skipped.
behzadnouri
force-pushed
the
shred-dedup-common-header
branch
from
c0f556d to
e151482
Compare
AshwinSekar
approved these changes
Dec 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Shreds in the retransmit stage:
Therefore in order to dedup shreds, it suffices to compare:
Because
ShredCommonHeaderalready includes all of the above tuple, the rest of the payload can be skipped.Summary of Changes
The commit dedups shreds by common-header and skips the rest of the payload.