Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds --snapshot-zstd-compression-level to agave-validator #4555

Merged
merged 2 commits into from
Jan 21, 2025

Conversation

brooksprumo
Copy link

@brooksprumo brooksprumo commented Jan 20, 2025

Problem

As snapshot sizes continue to grow on mnb, validators may want to set the zstd compression level to something other than 1. This is particularly pertinent for the Anza-run known validators, since they serve the majority of snapshots, and having them generate smaller snapshots could be a material benefit for the network as a whole.

Summary of Changes

Adds --snapshot-zstd-compression-level to agave-validator

Adding the cli arg to ledger-tool will be in a separate PR.

Fixes #3105

@brooksprumo brooksprumo self-assigned this Jan 20, 2025
@brooksprumo brooksprumo force-pushed the snap/compression-level-cli branch from cae78be to 67e7cd8 Compare January 21, 2025 02:20
@brooksprumo brooksprumo marked this pull request as ready for review January 21, 2025 03:22
jeffwashington
jeffwashington previously approved these changes Jan 21, 2025
Copy link

@jeffwashington jeffwashington left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

HaoranYi
HaoranYi previously approved these changes Jan 21, 2025
Copy link

@HaoranYi HaoranYi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.

@brooksprumo brooksprumo dismissed stale reviews from HaoranYi and jeffwashington via b3d51c7 January 21, 2025 15:38
@brooksprumo
Copy link
Author

Sorry, folks, I had to update the cli arg to remove .requires_if(), since I was using it incorrectly.

@brooksprumo brooksprumo merged commit 02fb093 into anza-xyz:master Jan 21, 2025
47 checks passed
@brooksprumo brooksprumo deleted the snap/compression-level-cli branch January 21, 2025 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cli arg for setting the zstd compression level
3 participants