Move calculation methods; partitioned epoch-rewards reorg, 4 of 5 #529
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #529 +/- ##
=======================================
Coverage 81.8% 81.8%
=======================================
Files 846 848 +2
Lines 229148 229154 +6
=======================================
+ Hits 187529 187574 +45
+ Misses 41619 41580 -39 |
This was referenced Apr 2, 2024
CriesofCarrots
force-pushed
the
simd-118-calc-sub
branch
from
43b1dac to
90e2856
Compare
|
This is the penultimate one @joncinque , so if we can roll through these last two, I can finally move on to substantive changes 🙏 |
|
Sorry for the delay, I will definitely get to the last ones today |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Code for partitioned epoch rewards is peppered throughout bank.rs. It is very hard to trace the flows, and figure out which structs and methods are needed for calculation vs distribution, or for sysvar handling.
Summary of Changes
Moves calculation-related methods to submodule of
bank::partitioned_epoch_rewardsMoves unit tests
Best reviewed by commit
This is PR 4 of 5 refactor this section of Bank code. The complete change is visible in a draft PR