Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rework remove_dead_accounts.reclaimed_offsets #571

Merged
merged 1 commit into from
Apr 4, 2024

Conversation

jeffwashington
Copy link

Problem

clean is inefficient and can be very slow.
A big offender is remove_dead_accounts.
This fn could be optimized by using a HashMap that organizes the requests by slot. We already had an Optional way to do that. We would like to always do that.

Summary of Changes

Always build reclaimed_offsets HashMap.

Fixes #

@jeffwashington jeffwashington marked this pull request as ready for review April 4, 2024 16:00
Copy link

@brooksprumo brooksprumo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

Refactor looks good to me.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.8%. Comparing base (0168e0a) to head (bd85ab8).
Report is 14 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##           master     #571     +/-   ##
=========================================
- Coverage    81.8%    81.8%   -0.1%     
=========================================
  Files         847      849      +2     
  Lines      229180   229190     +10     
=========================================
- Hits       187600   187551     -49     
- Misses      41580    41639     +59     

@jeffwashington jeffwashington merged commit ccdfd9a into anza-xyz:master Apr 4, 2024
38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants