rework remove_dead_accounts.reclaimed_offsets #571
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
clean is inefficient and can be very slow.
A big offender is
remove_dead_accounts
.This fn could be optimized by using a
HashMap
that organizes the requests by slot. We already had anOption
al way to do that. We would like to always do that.Summary of Changes
Always build
reclaimed_offsets
HashMap
.Fixes #