when flushing write cache, ignore reclaims

[jeffwashington]

Problem

reclaims are an old concept dating back to when we did not have the write cache. Reclaims are the bytes in an append vec which are now dead as a result of writing a second version of the same pubkey in the same append vec. The later entry supercedes the earlier one. When we are writing an append vec as a result of flushing the write cache, we only ever write each pubkey once. Thus, we do not need any reclaim behavior.

Summary of Changes

Ignore populating reclaims during write cache flushing.

Fixes #

[jeffwashington]

@brooksprumo I should've caught this one several years ago.

[brooksprumo]

Nice find!

[codecov-commenter]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.8%. Comparing base (2c11b7a) to head (5bd88d5).
Report is 4 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff            @@
##           master     #581     +/-   ##
=========================================
- Coverage    81.8%    81.8%   -0.1%     
=========================================
  Files         849      849             
  Lines      229183   229253     +70     
=========================================
+ Hits       187585   187601     +16     
- Misses      41598    41652     +54