PR634 1.17 backport #640
Closed
PR634 1.17 backport #640
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t-nelson
reviewed
Apr 7, 2024
| @@ -381,29 +381,57 @@ pub fn is_host_port(string: String) -> Result<(), String> { | |||
| parse_host_port(&string).map(|_| ()) | |||
| } | |||
|
|
|||
| #[derive(Clone, Debug, Default)] | |||
There was a problem hiding this comment.
1.17 toolchain's clippy is buggy and ignores allow(clippy::derivable_impls) here, so i went ahead and derived it since there shouldn't be much of a maintenance window on the 1.17 branch
steviez
reviewed
Apr 7, 2024
lijunwangs
commented
Apr 8, 2024
Closed
t-nelson
force-pushed
the
pr634-1.17
branch
2 times, most recently
from
2dec61f to
e56a2f2
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## v1.17 #640 +/- ##
========================================
Coverage 81.6% 81.6%
========================================
Files 806 806
Lines 219284 219436 +152
========================================
+ Hits 179002 179167 +165
+ Misses 40282 40269 -13 |
|
v1.17 is EOL |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Summary of Changes
Fixes #