[TieredStorage] Add AccountsFile::TieredStorage #72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Putting it back to draft to understand more about the test failure. |
|
Please readd me as a reviewer when the PR is ready. Thanks! |
yhchiang-sol
force-pushed
the
ts-pr-accounts-file-hot
branch
3 times, most recently
from
b76fd86 to
f4f04f9
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #72 +/- ##
=========================================
- Coverage 81.9% 81.8% -0.1%
=========================================
Files 840 840
Lines 228058 228105 +47
=========================================
+ Hits 186795 186815 +20
- Misses 41263 41290 +27 |
yhchiang-sol
force-pushed
the
ts-pr-accounts-file-hot
branch
4 times, most recently
from
37f4515 to
80b251e
Compare
yhchiang-sol
force-pushed
the
ts-pr-accounts-file-hot
branch
from
80b251e to
b5b3309
Compare
yhchiang-sol
commented
Mar 20, 2024
yhchiang-sol
changed the title
brooksprumo
reviewed
Mar 20, 2024
yhchiang-sol
force-pushed
the
ts-pr-accounts-file-hot
branch
from
51fe14a to
9ca4257
Compare
|
Rebase to address conflicts. |
yhchiang-sol
force-pushed
the
ts-pr-accounts-file-hot
branch
2 times, most recently
from
9db160d to
40030e1
Compare
yhchiang-sol
commented
Mar 22, 2024
brooksprumo
reviewed
Mar 22, 2024
brooksprumo
reviewed
Mar 22, 2024
brooksprumo
reviewed
Mar 22, 2024
yhchiang-sol
force-pushed
the
ts-pr-accounts-file-hot
branch
from
732964a to
717476f
Compare
|
Rebased and addressed comments. |
yhchiang-sol
force-pushed
the
ts-pr-accounts-file-hot
branch
from
717476f to
0c7053d
Compare
|
Rebased on top of master with #400 |
yhchiang-sol
force-pushed
the
ts-pr-accounts-file-hot
branch
from
0c7053d to
5f71d03
Compare
|
Rebased on top of #401 that includes the capacity() API. |
brooksprumo
reviewed
Mar 22, 2024
yhchiang-sol
force-pushed
the
ts-pr-accounts-file-hot
branch
from
5f71d03 to
8441131
Compare
|
Rebased on top of #401 |
brooksprumo
reviewed
Mar 23, 2024
yhchiang-sol
force-pushed
the
ts-pr-accounts-file-hot
branch
from
a33f52f to
6a825f1
Compare
yhchiang-sol
force-pushed
the
ts-pr-accounts-file-hot
branch
from
6a825f1 to
5b85d59
Compare
|
Rebased on top of master with #401 |
yhchiang-sol
added a commit
that referenced
this pull request
Mar 25, 2024
…ed-storage (#418) #### Problem As #72 introduced AccountsFile::TieredStorage, it also performs file-type check when opening an accounts-file to determine whether it is a tiered-storage or an append-vec. But before tiered-storage is enabled, this opening check is unnecessary. #### Summary of Changes Remove the accounts-file type check code and simply assume everything is append-vec on AccountsFile::new_from_file().
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
AccountsFile currently doesn't have an implementation for TieredStorage.
To enable AccountsDB tests for the TieredStorage, we need AccountsFile
to support TieredStorage.
Summary of Changes
This PR implements a AccountsFile::TieredStorage, a thin wrapper between
AccountsFile and TieredStorage.