Populate EpochRewards with correct data #763
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #763 +/- ##
=======================================
Coverage 81.9% 81.9%
=======================================
Files 851 851
Lines 231504 231526 +22
=======================================
+ Hits 189731 189781 +50
+ Misses 41773 41745 -28 |
CriesofCarrots
force-pushed
the
simd-118-correct-sysvar
branch
from
d4fd8a3 to
41b79a1
Compare
|
Rebased |
jstarry
reviewed
Apr 13, 2024
CriesofCarrots
force-pushed
the
simd-118-correct-sysvar
branch
from
41b79a1 to
f38764f
Compare
|
No changes in rebase aside from new last commit |
jstarry
previously approved these changes
Apr 13, 2024
CriesofCarrots
force-pushed
the
simd-118-correct-sysvar
branch
from
f38764f to
d62bb56
Compare
jstarry
approved these changes
Apr 15, 2024
joncinque
reviewed
Apr 15, 2024
michaelschem
pushed a commit
to michaelschem/agave
that referenced
this pull request
Apr 20, 2024
* Populate EpochRewards::parent_blockhash correctly * Populate EpochRewards::num_partitions correctly * Add new internal struct to be extended * Add CalculateValidatorRewardsResult::total_points * Add PartitionedRewardsCalculation::total_points * Add CalculateRewardsAndDistributeVoteRewardsResult::total_points * Populate EpochRewards::total_points correctly * Nit: reorder fields to match struct definition * Use Self::last_blockhash() to get parent_blockhash
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Bank::begin_partitioned_rewards()creates the EpochRewards sysvar with 3 default values, even though the data is all available at or after calculation.Summary of Changes
Populate the remainder of EpochRewards with real data. Namely, these fields:
parent_blockhash,num_partitions, andtotal_points.Exposing
total_pointsrequires an unfortunate amount of helper-struct plumbing, with the currentcalculationarchitecture. We could look at refactoring this, perhaps as part of the recalculation work.✅ Rebased
Sadly, because this touches the same dependency lists, this will have some dumb conflicts with #760. I'm happy to merge in either order.