Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renames fns to get_account_shared_data() #782

Merged
merged 1 commit into from
Apr 14, 2024

Conversation

brooksprumo
Copy link

Problem

Since #774, we now have get_account(), get_stored_account(), get_stored_account_meta(), and get_account_shared_data() methods, but AppendVec::get_stored_account() returns an AccountSharedData. I find this a bit confusing. If we rename get_stored_account(), I think that would help.

Summary of Changes

Renames the methods to get_account_shared_data() and updates callers.

@brooksprumo brooksprumo self-assigned this Apr 12, 2024
@brooksprumo brooksprumo marked this pull request as ready for review April 12, 2024 20:51
@codecov-commenter
Copy link

codecov-commenter commented Apr 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.9%. Comparing base (8c5a33a) to head (93cc7f2).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #782   +/-   ##
=======================================
  Coverage    81.9%    81.9%           
=======================================
  Files         851      851           
  Lines      231480   231480           
=======================================
+ Hits       189745   189774   +29     
+ Misses      41735    41706   -29     

jeffwashington
jeffwashington previously approved these changes Apr 13, 2024
Copy link

@jeffwashington jeffwashington left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@brooksprumo
Copy link
Author

Had to resolve merge conflicts due to #783, so I've rebased and force-pushed. No changes to the code though.

Copy link

@jeffwashington jeffwashington left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@brooksprumo brooksprumo merged commit 2ffc7f6 into anza-xyz:master Apr 14, 2024
38 checks passed
@brooksprumo brooksprumo deleted the av/get_account_shared_data branch April 15, 2024 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants