accounts db/refactor accounts db test - add macro for accounts-db panic test #786
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HaoranYi
changed the title
|
The actual change is in the last commit. |
brooksprumo
reviewed
Apr 15, 2024
brooksprumo
reviewed
Apr 15, 2024
| #[test_case(AccountsFileProvider::AppendVec; "append_vec")] | ||
| #[test_case(AccountsFileProvider::HotStorage; "hot_storage")] | ||
| fn $name(accounts_file_provider: AccountsFileProvider) { | ||
| (@testfn $name:ident, $accounts_file_provider: ident, |$accounts_db:ident| $inner: tt) => { |
HaoranYi
changed the title
added 2 commits
April 17, 2024 14:26
convert double remove test for both account file provider
HaoranYi
force-pushed
the
accounts-db/refactor_accounts_db_test3
branch
from
97c1b2e to
4b17876
Compare
|
No code change. Rebase to master to pick up #784. |
|
@jeffwashington Can you help to review this PR? Thanks! |
There are 9 more tests that expect panics. |
michaelschem
pushed a commit
to michaelschem/agave
that referenced
this pull request
Apr 20, 2024
…ic test (anza-xyz#786) * add macro for accounts-db panic test convert double remove test for both account file provider * refactor to share accounts_db_test and accounts_db_panic_test macro * rebase --------- Co-authored-by: HaoranYi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
add macro for accounts-db panic test
Continued on #784
Summary of Changes
Fixes #