-
Notifications
You must be signed in to change notification settings - Fork 337
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate is_builtin_key_or_sysvar
function
#788
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #788 +/- ##
=========================================
- Coverage 81.9% 81.8% -0.2%
=========================================
Files 851 851
Lines 231480 231678 +198
=========================================
- Hits 189728 189580 -148
- Misses 41752 42098 +346 |
a191136
to
deda637
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally lgtm. Just one small thought to make is_account_maybe_reserved()
more readable to my brain.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me overall! Just a couple of questions
deda637
to
2c1a280
Compare
Problem
The public
is_builtin_key_or_sysvar
function uses static lists of sdk keys and should be removed in favor of using the newReservedAccountKeys
struct.Summary of Changes
is_builtin_key_or_sysvar
is_maybe_writable
methods to accept an optional set of reserved keys. The reason it's optional is so that clients can opt out of providing the reserved key set if they don't care about it. Note that this method isn't to be used by the runtime so there's no need to enforce that a reserved key set is passed.Breaking Changes
v0::Message::is_maybe_writable
has an additional param for passing reserved account keysVersionedMessage::is_maybe_writable
has an additional param for passing reserved account keysFixes #