Deprecate is_sysvar_id function
#789
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jstarry
force-pushed
the
deprecate-is-sysvar
branch
from
b203d73 to
9683d5b
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #789 +/- ##
=======================================
Coverage 81.9% 81.9%
=======================================
Files 851 851
Lines 231504 231505 +1
=======================================
+ Hits 189731 189736 +5
+ Misses 41773 41769 -4 |
michaelschem
pushed a commit
to michaelschem/agave
that referenced
this pull request
Apr 20, 2024
Deprecate is_sysvar_id
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The public
is_sysvar_idfunction uses static lists of sysvar keys and should be removed in favor of using the newReservedAccountKeysstruct.Summary of Changes
is_sysvar_idis_sysvar_idin ledger tool and the bigtable clientFixes #