use callback for account and account_default_if_zero_lamport #819
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeffwashington
force-pushed
the
4a70_callback
branch
2 times, most recently
from
bb32f81 to
8d274c7
Compare
jeffwashington
force-pushed
the
4a70_callback
branch
from
8d274c7 to
4002998
Compare
michaelschem
pushed a commit
to michaelschem/agave
that referenced
this pull request
Apr 20, 2024
…z#819) use callback for `account` and `account_default_if_zero_lamport`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
moving to not mmapping append vec files. Soon, lifetimes of borrowed account data will be limited to a callback.
Summary of Changes
Rework
StorableAccounts.account()andaccount_default_if_zero_lamport)to use a callback.The next change will push the callback up to getting the data from the storage. This change was done to simplify the diff and take one step at a time.
Fixes #