Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Marks append vec test utils as DCOU #820

Merged
merged 1 commit into from
Apr 15, 2024

Conversation

brooksprumo
Copy link

Problem

AppendVec's test_utils module can be called by non-tests.

Summary of Changes

Mark it as DCOU.

@brooksprumo brooksprumo self-assigned this Apr 15, 2024
@brooksprumo brooksprumo marked this pull request as ready for review April 15, 2024 20:20
@brooksprumo brooksprumo requested a review from HaoranYi April 15, 2024 20:20
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.8%. Comparing base (9ba0d6f) to head (40a5d01).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #820   +/-   ##
=======================================
  Coverage    81.8%    81.8%           
=======================================
  Files         851      851           
  Lines      231556   231556           
=======================================
+ Hits       189449   189505   +56     
+ Misses      42107    42051   -56     

Copy link

@HaoranYi HaoranYi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@brooksprumo brooksprumo merged commit f16b5cf into anza-xyz:master Apr 15, 2024
38 checks passed
@brooksprumo brooksprumo deleted the dcou/append-vec-test-utils branch April 16, 2024 12:25
michaelschem pushed a commit to michaelschem/agave that referenced this pull request Apr 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants