hot storage tests don't use Option #821
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brooksprumo
reviewed
Apr 15, 2024
| @@ -47,12 +46,11 @@ pub(super) fn create_test_account(seed: u64) -> (StoredMeta, AccountSharedData) | |||
|
|
|||
| pub(super) fn verify_test_account( | |||
| stored_meta: &StoredAccountMeta<'_>, | |||
| account: Option<&impl ReadableAccount>, | |||
| acc: &impl ReadableAccount, | |||
There was a problem hiding this comment.
Was this parameter renamed to keep line 53 on a single line?
There was a problem hiding this comment.
was just trying to use the name that it already was in the usage below (acc)
michaelschem
pushed a commit
to michaelschem/agave
that referenced
this pull request
Apr 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
moving to not mmapping append vec files. Soon, lifetimes of borrowed account data will be limited to a callback.
Summary of Changes
Rework
StorableAccountsWithHashes.account()andget()to always return an account. If lamports=0, a default account will be returned. The easiest first step to take here is to fix the test fns for hot storage. That avoids unnecessary mess in that change.The next change will be to push the removal of the
Optionfurther up the call chain.Fixes #