Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ignore mio security advisory #91

Closed
wants to merge 1 commit into from

Conversation

bw-solana
Copy link

Problem

Per discussion in #60 - prefer to ignore Windows only warning rather than update mio crate

Summary of Changes

  1. Roll back mio to v0.8.8
  2. Ignore security advisory

@bw-solana bw-solana marked this pull request as ready for review March 5, 2024 15:52
@bw-solana bw-solana requested a review from yihau March 5, 2024 15:52
@yihau
Copy link
Member

yihau commented Mar 5, 2024

oh! I thought we only ignore it for backport 🤔 iirc we usually upgrade things on master. would like to wait for @t-nelson's opinion haha

@yihau yihau requested a review from t-nelson March 5, 2024 16:17
@bw-solana
Copy link
Author

oh! I thought we only ignore it for backport 🤔 iirc we usually upgrade things on master. would like to wait for @t-nelson's opinion haha

Ah, yeah, you're probably right. Brain working slow

@t-nelson
Copy link

t-nelson commented Mar 5, 2024

yeah just the backports, bump is fine in master 😅

@bw-solana bw-solana closed this Mar 5, 2024
@bw-solana bw-solana deleted the mio_security_advisory branch March 5, 2024 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants