Refactor log_messages_bytes_limit parameter usage

[andreisilviudragnea]

Problem

There are many functions with a long list of parameters and some of them can be removed by refactoring how those parameters are used. For example, log_messages_bytes_limit parameter can be retrieved directly from RuntimeConfig struct.

Summary of Changes

Replacing log_messages_bytes_limit parameter inside TransactionBatchProcessor::execute_loaded_transaction() with self.runtime_config.log_messages_bytes_limit allows removing many log_messages_bytes_limit parameters propagated across the codebase.

[andreisilviudragnea]

@steviez What do you think about this?

[andreisilviudragnea]

@CriesofCarrots Do you think this PR could be helpful?

[buffalojoec]

Hey @andreisilviudragnea thanks for the contributions! I'd like to ask respectfully that you don't tag maintainers. One of us will definitely have a look at your proposed changes, we are just very busy!

Conceptually this looks like a nice cleanup. I'll look at this as soon as possible, unless someone beats me to it!

[andreisilviudragnea]

I see some failures in https://buildkite.com/anza/agave/builds/3584#018f1cb8-3593-42cd-9f49-c5cf61cb8fdf:

     Summary [ 530.880s] 5 tests run: 4 passed (3 slow), 1 failed, 48 skipped
        FAIL [ 247.644s] solana-local-cluster::local_cluster test_hard_fork_with_gap_in_roots

But they do not seem related to this PR, since the same test fails on master builds too (https://buildkite.com/anza/agave/builds/3583), but passes after some retries (https://buildkite.com/anza/agave/builds/3595).

I will rebase my PR and wait for CI tag to run CI again.

[steviez]

Generally, I like this change as we have lots of bloated argument lists in the codebase. That being said, this one looks like it might be a slight change of behavior.

• Currently, callers of this function will always get a value of Some(1e6)
• With your change, the value will be whatever is initialized in the first Bank (ie CLI arg)

It looks like we have this caller here; I'm not super familiar with BanksServer so will need to dig a little (or let someone else chime in) to ensure we're good with the change:

agave/banks-server/src/banks_server.rs

Line 371 in b35e17c

match bank.process_transaction_with_metadata(transaction) {