[SOL] Create explicit sign extension instruction #114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
looks good, except for minor naming inconsistencies. If you have setHasExplicitSext (which I think should be setHasExplicitSignExt), maybe the getter should also be getHasExplicitSignExt, instead of getExplicitSignExt. |
LucasSte
force-pushed
the
explicit-sign-ext-instr
branch
from
74c6d84 to
fe185ba
Compare
dmakarov
approved these changes
Dec 2, 2024
LucasSte
merged commit f602770
into
anza-xyz:solana-rustc/18.1-2024-05-19
15 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As described in solana-foundation/solana-improvement-documents#174,
mov32 reg, regwill now serve for sign extension.The changes in this PR are the following:
mov64for copying 32-bit registers.mov32 reg, regfor sign extension.mov64 reg, regfor zero extension. I'm assuming I'll always keep the high bits clear in 32-bit sub-registers.and32 reg, -1for truncation.I haven't done yet an integration test in the VM, because jump instructions do not work with ALU32. I'll fix that in a following PR and work on the necessary tests.