Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump ubuntu version #82

Merged
merged 2 commits into from
Oct 4, 2024
Merged

Bump ubuntu version #82

merged 2 commits into from
Oct 4, 2024

Conversation

LucasSte
Copy link
Collaborator

@LucasSte LucasSte commented Sep 30, 2024

Ubuntu 20 is going to lose support this year. Additionally, it comes with Python 3.8, which is no longer supported.

See: #79

@i1i1
Copy link

i1i1 commented Oct 3, 2024

I guess this line is no longer required:

cp -R rust/build/${HOST_TRIPLE}/llvm/lib/python* deploy/llvm/lib/

You can allow it to fail like this cp -R rust/build/${HOST_TRIPLE}/llvm/lib/python* deploy/llvm/lib/ || true

@LucasSte
Copy link
Collaborator Author

LucasSte commented Oct 3, 2024

I guess this line is no longer required:

cp -R rust/build/${HOST_TRIPLE}/llvm/lib/python* deploy/llvm/lib/

You can allow it to fail like this cp -R rust/build/${HOST_TRIPLE}/llvm/lib/python* deploy/llvm/lib/ || true

It is required. Python wasn't built due to a missing component.

@LucasSte
Copy link
Collaborator Author

LucasSte commented Oct 3, 2024

The Python folder is necessary to run the Solana debugger. We need python3-dev and swig on Ubuntu for it to be created. It works on MacOS (see the CI), but on Linux the folder silently isn't constructed.

@LucasSte LucasSte requested a review from dmakarov October 4, 2024 00:19
@LucasSte LucasSte marked this pull request as ready for review October 4, 2024 00:19
Copy link

@i1i1 i1i1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing it! Checked the artifacts, not python version is 3.10!

@LucasSte LucasSte merged commit b136345 into anza-xyz:master Oct 4, 2024
5 checks passed
@LucasSte LucasSte deleted the bump-ubuntu branch October 4, 2024 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants