Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CodeQL security scanning on pull requests. #44404

Merged
merged 1 commit into from
Nov 27, 2024

Conversation

potiuk
Copy link
Member

@potiuk potiuk commented Nov 27, 2024

Apparently we only run codeql on main, but we could run it on PRs as well. That's a good idea to test how it can look like.


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

Apparently we only run codeql on main, but we could run it on PRs
as well. That's a good idea to test how it can look like.
@potiuk
Copy link
Member Author

potiuk commented Nov 27, 2024

This seems to work well.

Copy link
Contributor

@amoghrajesh amoghrajesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM +1
Should we just mark 2-10* specifically?

@potiuk
Copy link
Member Author

potiuk commented Nov 27, 2024

LGTM +1 Should we just mark 2-10* specifically?

We have the same pattern elsewhere - and we are going to have 2.11 in the future, so better to keep it this way I think.

@potiuk
Copy link
Member Author

potiuk commented Nov 27, 2024

And in the future we will have 3_0, 3_1 etc. ....

@potiuk potiuk merged commit 6f0d731 into apache:main Nov 27, 2024
100 checks passed
@potiuk potiuk deleted the add-security-scanning-on-pull-request branch November 27, 2024 14:23
prabhusneha pushed a commit to astronomer/airflow that referenced this pull request Nov 28, 2024
Apparently we only run codeql on main, but we could run it on PRs
as well. That's a good idea to test how it can look like.
LefterisXefteris pushed a commit to LefterisXefteris/airflow that referenced this pull request Jan 5, 2025
Apparently we only run codeql on main, but we could run it on PRs
as well. That's a good idea to test how it can look like.
got686-yandex pushed a commit to got686-yandex/airflow that referenced this pull request Jan 30, 2025
Apparently we only run codeql on main, but we could run it on PRs
as well. That's a good idea to test how it can look like.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants