[v2-10-test] Improve speed of tests by not creating connections at parse time (#45690) #45826
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
…rse time (#45690) The DAG serialization tests load all of the example and system test DAGs, and there were two places that these tests opened connections at parse time resulting in loads of extra of test time. - The SystemTestContextBuilder was trying to fetch things from SSM. This was addressed by adding a functools.cache on the function - The Bedrock example dag was setting/caching the underlying conn object globally. This was addressed by making the Airflow connection a global, rather than the Bedrock conn. This fix is not _great_, but it does massively help Before: > 111 passed, 1 warning in 439.37s (0:07:19) After: > 111 passed, 1 warning in 71.76s (0:01:11) (cherry picked from commit 102e853) Co-authored-by: Ash Berlin-Taylor <[email protected]>
ashb
approved these changes
Jan 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The DAG serialization tests load all of the example and system test DAGs, and
there were two places that these tests opened connections at parse time
resulting in loads of extra of test time.
addressed by adding a functools.cache on the function
globally. This was addressed by making the Airflow connection a global,
rather than the Bedrock conn. This fix is not great, but it does massively
help
Before:
After:
Co-authored-by: Ash Berlin-Taylor [email protected]