Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Replace bootstrap script with explicit Cython declarations #669

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

refactor: Replace bootstrap script with explicit Cython declarations #669

wants to merge 2 commits into from

Conversation

WillAyd
Copy link
Contributor

@WillAyd WillAyd commented Oct 29, 2024

No description provided.

@WillAyd
Copy link
Contributor Author

WillAyd commented Oct 31, 2024

Latest commit replaces our custom bootstrapping with autopxd2.

If does generate the following warnings at runtime:

<frozen importlib._bootstrap>:241
  <frozen importlib._bootstrap>:241: UserWarning: enum class ArrowTimeUnit not importable from nanoarrow_c. You are probably using a cpdef enum declared in a .pxd file that does not have a .py  or .pyx file.

need to investigate further but I think this has the potential to greatly simplify our Python build system

@WillAyd WillAyd mentioned this pull request Nov 14, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@WillAyd