Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
Co-authored-by: Andrew Lamb <[email protected]>
  • Loading branch information
rluvaton and alamb authored Dec 18, 2024
1 parent d86dcc9 commit 5d48eda
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 3 deletions.
5 changes: 3 additions & 2 deletions arrow-array/src/builder/generic_bytes_dictionary_builder.rs
Original file line number Diff line number Diff line change
Expand Up @@ -305,9 +305,10 @@ where
};
}

/// Extends builder with dictionary
/// Extends builder with an existing dictionary array.
///
/// This is the same as `extends` but avoid lookup for each item in the iterator
/// This is the same as [`Self::extend`] but is faster as it translates
/// the dictionary values once rather than doing a lookup for each item in the iterator
///
/// when dictionary values are null (the actual mapped values) the keys are null
///
Expand Down
3 changes: 2 additions & 1 deletion arrow-array/src/builder/primitive_dictionary_builder.rs
Original file line number Diff line number Diff line change
Expand Up @@ -307,7 +307,8 @@ where

/// Extends builder with dictionary
///
/// This is the same as `extends` but avoid lookup for each item in the iterator
/// This is the same as [`Self::extend`] but is faster as it translates
/// the dictionary values once rather than doing a lookup for each item in the iterator
///
/// when dictionary values are null (the actual mapped values) the keys are null
///
Expand Down

0 comments on commit 5d48eda

Please sign in to comment.