Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove some very old deprecated functions #6774

Merged
merged 2 commits into from
Nov 22, 2024
Merged

Remove some very old deprecated functions #6774

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
30a63ab
Remove some very old deprecated functions
alamb Nov 22, 2024
9a0d4d0
fix
alamb Nov 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions arrow-array/src/array/struct_array.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -239,12 +239,6 @@ impl StructArray {
&self.fields
}

/// Returns child array refs of the struct array
#[deprecated(note = "Use columns().to_vec()")]
pub fn columns_ref(&self) -> Vec<ArrayRef> {
self.columns().to_vec()
}

/// Return field names in this struct array
pub fn column_names(&self) -> Vec<&str> {
match self.data_type() {
Expand Down
36 changes: 0 additions & 36 deletions parquet/src/file/properties.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -185,14 +185,6 @@ impl WriterProperties {
WriterPropertiesBuilder::with_defaults()
}

/// Returns data page size limit.
///
/// Note: this is a best effort limit based on the write batch size
#[deprecated(since = "41.0.0", note = "Use data_page_size_limit")]
pub fn data_pagesize_limit(&self) -> usize {
self.data_page_size_limit
}

/// Returns data page size limit.
///
/// Note: this is a best effort limit based on the write batch size
Expand All @@ -202,14 +194,6 @@ impl WriterProperties {
self.data_page_size_limit
}

/// Returns dictionary page size limit.
///
/// Note: this is a best effort limit based on the write batch size
#[deprecated(since = "41.0.0", note = "Use dictionary_page_size_limit")]
pub fn dictionary_pagesize_limit(&self) -> usize {
self.dictionary_page_size_limit
}

/// Returns dictionary page size limit.
///
/// Note: this is a best effort limit based on the write batch size
Expand Down Expand Up @@ -433,16 +417,6 @@ impl WriterPropertiesBuilder {
self
}

/// Sets best effort maximum size of a data page in bytes.
///
/// Note: this is a best effort limit based on value of
/// [`set_write_batch_size`](Self::set_write_batch_size).
#[deprecated(since = "41.0.0", note = "Use set_data_page_size_limit")]
pub fn set_data_pagesize_limit(mut self, value: usize) -> Self {
self.data_page_size_limit = value;
self
}

/// Sets best effort maximum size of a data page in bytes (defaults to `1024 * 1024`).
///
/// The parquet writer will attempt to limit the sizes of each
Expand Down Expand Up @@ -471,16 +445,6 @@ impl WriterPropertiesBuilder {
self
}

/// Sets best effort maximum dictionary page size, in bytes.
///
/// Note: this is a best effort limit based on value of
/// [`set_write_batch_size`](Self::set_write_batch_size).
#[deprecated(since = "41.0.0", note = "Use set_dictionary_page_size_limit")]
pub fn set_dictionary_pagesize_limit(mut self, value: usize) -> Self {
self.dictionary_page_size_limit = value;
self
}

/// Sets best effort maximum dictionary page size, in bytes (defaults to `1024 * 1024`).
///
/// The parquet writer will attempt to limit the size of each
Expand Down
Loading