Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[53.0.0_maintenance] fix: decimal conversion looses value on lower precision (#6836) #6936

Merged

Conversation

andygrove
Copy link
Member

@andygrove andygrove commented Jan 3, 2025

Which issue does this PR close?

Part of #6887

Rationale for this change

Backports #6836 to 53.x.x

What changes are included in this PR?

Are there any user-facing changes?

* decimal conversion looses value on lower precision, throws error now on overflow.

* fix review comments and fix formatting.

* for simple case of equal scale and bigger precision, no conversion needed.

revert whitespace changes

formatting check

---------

Co-authored-by: himadripal <[email protected]>
@github-actions github-actions bot added the arrow Changes to the arrow crate label Jan 3, 2025
@alamb
Copy link
Contributor

alamb commented Jan 4, 2025

Thanks @andygrove -- I am looking at the CI failures now

@alamb
Copy link
Contributor

alamb commented Jan 4, 2025

The clippy issue seems to have been fixed by #6791 -- I will create a backport PR for that:

@alamb
Copy link
Contributor

alamb commented Jan 4, 2025

Here is a proposed workaround for the docs failure:

@alamb
Copy link
Contributor

alamb commented Jan 4, 2025

The archery test faolure appears to be some transient failure: https://github.com/apache/arrow-rs/actions/runs/12603098780/job/35127463445?pr=6936

Integration: Test: Result
  ################# FAILURES #################
  FAILED TEST: dictionary Rust producing,  Rust consuming
  <class 'RuntimeError'>: Command failed: /build/rust/debug/flight-test-integration-client --host localhost --port=36655 --path /tmp/arrow-integration-o2tv9_3_/generated_dictionary.json
  With output:
  --------------
  Error: tonic::transport::Error(Transport, ConnectError(ConnectError("tcp connect error", Os { code: 111, kind: ConnectionRefused, message: "Connection refused" })))
  
  --------------  

I will retrigger to be sure

Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me -- thanks @andygrove

@alamb alamb merged commit e4cb337 into apache:53.0.0_maintenance Jan 5, 2025
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arrow Changes to the arrow crate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants