Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document the ParquetRecordBatchStream buffering #6947

Merged
merged 2 commits into from
Jan 8, 2025
Merged

Document the ParquetRecordBatchStream buffering #6947

merged 2 commits into from
Jan 8, 2025
+14 −2

Conversation

alamb
Copy link
Contributor

@alamb alamb commented Jan 6, 2025

Which issue does this PR close?

Rationale for this change

There was some surprise that the ParquetRecordBatchStream buffered entire row groups during decode, so let's documet this better.

What changes are included in this PR?

  1. Document buffering in ParquetRecordBatchStream

Are there any user-facing changes?

Docs

@alamb alamb changed the title Document the ParquetRecordBatchStream buffering Document the ParquetRecordBatchStream buffering Jan 6, 2025
@alamb alamb added the documentation Improvements or additions to documentation label Jan 6, 2025
@alamb alamb mentioned this pull request Jan 6, 2025
Open
@github-actions github-actions bot added the parquet Changes to the parquet crate label Jan 7, 2025
@alamb alamb merged commit f18dadd into apache:main Jan 8, 2025
16 checks passed
@alamb
Copy link
Contributor Author

alamb commented Jan 8, 2025

Thanks @tustvold

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tustvold tustvold tustvold approved these changes

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation parquet Changes to the parquet crate
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alamb @tustvold