Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MINOR: [Docs] Update implementation matrix for view types in arrow-rs #44175

Merged
merged 1 commit into from
Sep 20, 2024

Conversation

wiedld
Copy link
Contributor

@wiedld wiedld commented Sep 20, 2024

Rationale for this change

BinaryView and Utf8View are now supported in arrow-rs as of the 52.0.0 release.

What changes are included in this PR?

Add two checkmarks for the Data Type support.

Are these changes tested?

N/A

Are there any user-facing changes?

N/A

@kou kou changed the title MINOR: update implementation matrix for view types in arrow-rs MINOR: [Docs] Update implementation matrix for view types in arrow-rs Sep 20, 2024
@kou
Copy link
Member

kou commented Sep 20, 2024

@github-actions crossbow submit preview-docs

@kou
Copy link
Member

kou commented Sep 20, 2024

@alamb arrow-rs doesn't support Large Binary View/Large Utf8 View yet, right?

Copy link

Revision: d4baded

Submitted crossbow builds: ursacomputing/crossbow @ actions-4902899983

Task Status
preview-docs GitHub Actions

@alamb
Copy link
Contributor

alamb commented Sep 20, 2024

@alamb arrow-rs doesn't support Large Binary View/Large Utf8 View yet, right?

That is correct -- I didn't even remember there was such a thing 😢 I am losing track

Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @wiedld

@github-actions github-actions bot added awaiting merge Awaiting merge and removed awaiting review Awaiting review labels Sep 20, 2024
@alamb
Copy link
Contributor

alamb commented Sep 20, 2024

I double checked that there is no more use of the merging script mentioned in
https://arrow.apache.org/docs/developers/reviewing.html and recent PRs like #44170 appear to have been merged via the github button.

@github-actions crossbow submit preview-docs

@kou do we need to wait for any other tests for the docs? All the tests I can see on this PR and the crossbow docs in #44175 (comment) seem to be passing now

@kou
Copy link
Member

kou commented Sep 20, 2024

@kou
Copy link
Member

kou commented Sep 20, 2024

Thanks for confirming the Large Binary View/Large Utf8 View statuses.

I confirmed that rendered HTML is good.

We're still using the merge script https://github.com/apache/arrow/blob/main/dev/merge_arrow_pr.py . I used it to merge #44170 .

All document related CIs were passed. So this is ready to merge. I'll merge this by the merge script.

@kou kou merged commit b153791 into apache:main Sep 20, 2024
8 checks passed
@kou kou removed the awaiting merge Awaiting merge label Sep 20, 2024
Copy link

After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit b153791.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details. It also includes information about 5 possible false positives for unstable benchmarks that are known to sometimes produce them.

@alamb
Copy link
Contributor

alamb commented Sep 21, 2024

Thank you @kou

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants