-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MINOR: [Docs] Update implementation matrix for view types in arrow-rs #44175
Conversation
@github-actions crossbow submit preview-docs |
@alamb arrow-rs doesn't support Large Binary View/Large Utf8 View yet, right? |
Revision: d4baded Submitted crossbow builds: ursacomputing/crossbow @ actions-4902899983
|
That is correct -- I didn't even remember there was such a thing 😢 I am losing track |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @wiedld
I double checked that there is no more use of the merging script mentioned in
@kou do we need to wait for any other tests for the docs? All the tests I can see on this PR and the crossbow docs in #44175 (comment) seem to be passing now |
The preview URL: http://crossbow.voltrondata.com/pr_docs/44175/status.html |
Thanks for confirming the Large Binary View/Large Utf8 View statuses. I confirmed that rendered HTML is good. We're still using the merge script https://github.com/apache/arrow/blob/main/dev/merge_arrow_pr.py . I used it to merge #44170 . All document related CIs were passed. So this is ready to merge. I'll merge this by the merge script. |
After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit b153791. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 5 possible false positives for unstable benchmarks that are known to sometimes produce them. |
Thank you @kou |
Rationale for this change
BinaryView and Utf8View are now supported in arrow-rs as of the 52.0.0 release.
What changes are included in this PR?
Add two checkmarks for the Data Type support.
Are these changes tested?
N/A
Are there any user-facing changes?
N/A