GH-44800: [C#] Implement Flight SQL Client #44783
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
**GetExportedKeys**
- Retrieves a description about the foreign key columns that reference the primary key columns of the given table.
- **GetExportedKeysSchema**
- Get the exported keys schema from the server.
- **GetImportedKeys**
- Retrieves the foreign key columns for the given table.
- **GetImportedKeysSchema**
- Get the imported keys schema from the server.
- **GetCrossReference**
- Retrieves a description of the foreign key columns in the given foreign key table that reference the primary key or the columns representing a unique constraint of the parent table.
- **GetCrossReferenceSchema**
- Get the cross reference schema from the server.
- **GetTableTypes**
- Request a list of table types.
- **GetTableTypesSchema**
- Get the table types schema from the server.
- **GetXdbcTypeInfo**
- Request the information about all the data types supported.
- **GetXdbcTypeInfo (with data_type parameter)**
- Request the information about a specific data type supported.
- **GetXdbcTypeInfoSchema**
- Get the type info schema from the server.
- **GetSqlInfo**
- Request a list of SQL information.
- **GetSqlInfoSchema**
…t/flight-sql-client
# Conflicts: # csharp/src/Apache.Arrow.Flight/Client/FlightClient.cs # csharp/test/Apache.Arrow.Flight.Tests/FlightTests.cs
…htSqlServer.cs
csharp/Apache.Arrow.Flight.Sql.TestWeb/TestFlightSqlServer.cs
var batches = flightHolder.GetRecordBatches();
foreach (var batch in batches)
{
await responseStream.WriteAsync(batch.RecordBatch, batch.Metadata);
Add ConfigureAwait(false)
- PreparedStatement implementation - SqlActions adding command requests -- Commit -- Rollback -- BeginTransaction -- CancelFlightInfo
lidavidm
reviewed
Nov 18, 2024
csharp/src/Apache.Arrow.Flight.Sql/Apache.Arrow.Flight.Sql.csproj
Outdated
Show resolved
Hide resolved
Sure, sir, I will do everything mentioned here. Thank you for your guidelines. |
added 5 commits
November 20, 2024 08:49
HackPoint
changed the title
|
|
github-actions
bot
added
awaiting committer review
|
I approved the workflows. I don't work on C# sharp but wanted to thank you @HackPoint for such a big first-time contribution! |
Can you please review the code and allow me to close the PR please? |
I will review this tonight. |
|
Could you revert all |
|
I’ve haven’t made any changes in c++, but I’ll re-fork and cherry-pick my
code into a new fork and push all the changes.
…On Tue, 26 Nov 2024 at 7:28 Sutou Kouhei ***@***.***> wrote:
Could you revert all cpp/ changes?
—
Reply to this email directly, view it on GitHub
<#44783 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABTSBM7DBABI7X26GBOCS7D2CQBGVAVCNFSM6AAAAABSAGSJF6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIOJZGY4TEMRQGI>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
seems that it's done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GH-44800: [C#] Implement Flight SQL Client
Rationale for this Change
This pull request introduces a new implementation of
FlightSqlClientandPreparedStatementin C#. Previously, there was no C# client for Flight SQL, leaving a significant gap for .NET developers who wished to interact with Flight SQL servers.The implementation aligns with the existing C++ Flight SQL client API, ensuring consistent and familiar behavior across languages and providing a robust client for the Apache Arrow ecosystem in .NET.
What's Included in this PR?
Key Features
FlightSqlClient:ExecuteAsync,ExecuteUpdateAsync) and schema retrieval (GetCatalogsAsync,GetDbSchemasAsync, etc.).PreparedStatement:SetParameters,ExecuteAsync, andExecuteUpdateAsync).CloseAsync) for effective resource handling.API Consistency
This implementation mirrors the C++ Flight SQL client to ensure API alignment across supported languages:
Are These Changes Tested?
Testing Overview
Unit Tests:
PreparedStatement.GetCatalogsAsyncandGetDbSchemasAsync.Integration Tests:
End-to-End Tests:
Example Test Cases
ExecuteUpdateAsync.Are There Any Breaking Changes?
This PR introduces new functionality and does not affect any existing features. There are no breaking changes.
Are There Any User-Facing Changes?
New Capabilities
FlightSqlClient:
PreparedStatement:
API Consistency
Additional Notes
async/awaitfor non-blocking operations.Resources
Feedback and Suggestions
Thank you for reviewing this contribution! Suggestions and feedback are welcome to ensure the implementation meets the project's standards and requirements.