Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BIGTOP-4165: Correct MySQL DDL to make add host step progress #22

Merged
merged 1 commit into from
Jul 22, 2024
Merged

BIGTOP-4165: Correct MySQL DDL to make add host step progress #22

merged 1 commit into from
Jul 22, 2024

Conversation

HalimKim
Copy link
Contributor

No description provided.

@kevinw66
Copy link
Contributor

Thanks, @HalimKim , How about we remove jpa autocreation and use this DDL file to create all related tables?

@HalimKim
Copy link
Contributor Author

@kevinw66 Sounds good, Actually I wanted to do that.
It would be better for developers to understand mysql schema. thank you.

kevinw66
kevinw66 approved these changes Jul 22, 2024
View reviewed changes
Copy link
Contributor

@kevinw66 kevinw66 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 LGTM, thanks @HalimKim

@kevinw66 kevinw66 merged commit 5a35e51 into apache:main Jul 22, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevinw66 kevinw66 kevinw66 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@HalimKim @kevinw66