ci: add typo ci check and fix typos #4375
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dlg99
approved these changes
May 19, 2024
hezhangjian
force-pushed
the
typo-check
branch
4 times, most recently
from
166328d to
1bff8a6
Compare
hezhangjian
changed the title
hezhangjian
requested review from
hangc0276,
dlg99,
eolivelli,
wenbingshen,
StevenLuMT,
merlimat and
zymap
Signed-off-by: ZhangJian He <[email protected]>
|
|
hangc0276
approved these changes
May 26, 2024
|
This broke. PR to fix it #4433. @shoothzj Please notice that in the future, we shouldn't be adding any external actions to run in apache/bookkeeper repository context because of security reasons. It's only fine for pull_request builds since they don't have access to the repository. More details in https://docs.github.com/en/actions/security-guides/security-hardening-for-github-actions#using-third-party-actions . |
|
@lhotari Thanks for the heads-up and the link to the security practices! I'll make sure to adjust the approach accordingly for future contributions. |
Ghatage
pushed a commit
to sijie/bookkeeper
that referenced
this pull request
Jul 12, 2024
### Motivation Introduce typos ci to avoid typos. See https://lists.apache.org/thread/04hqqcnkfc5189zsxj0s5wm37t2x7bky Signed-off-by: ZhangJian He <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Introduce typos ci to avoid typos. See https://lists.apache.org/thread/04hqqcnkfc5189zsxj0s5wm37t2x7bky