Replace assert statements with explicit checks #4390
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Main Issue #995
Motivation
In the current implementation, several components use
assert
statements to verify conditions. However, assert statements are not typically enabled in production environments, which means these checks can be bypassed, potentially leading to unclear errors later in the execution. Replacing these with explicit checks ensures that our error handling is active and clear during production runs.Changes
BKTransmitPacket
.dlConfig
before casting toBKDLConfig
.OpResult.ErrorResult
.