improve: Use opstatlogger for recording more details of reading from db ledger #4472
+44
−31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hezhangjian
approved these changes
Jul 26, 2024
|
@shoothzj PTAL， i had add a new commit |
|
@ethqunzhong Please fix the check style, thanks. |
ethqunzhong
force-pushed
the
update-dbledgerstoragestats-metrics
branch
from
bc971e5 to
68d55fc
Compare
@hangc0276 updated. thx~ |
StevenLuMT
reviewed
Feb 15, 2025
| parent = READ_ENTRY | ||
| ) | ||
| private final Counter readFromEntryLogTime; | ||
| private final OpStatsLogger readFromEntryLogTime; |
There was a problem hiding this comment.
Break change for metric readFromEntryLogTime, I think this may need to send the mail vote. @eolivelli @dlg99 , please help evaluate it.
StevenLuMT
requested changes
Feb 15, 2025
There was a problem hiding this comment.
Break change for metric readFromEntryLogTime, I think this may need to send the mail vote. @eolivelli @dlg99 , please help evaluate it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
In order to more accurately observe the latency distribution of reading entries from the db ledger storage engine (includes: read_locations_index, read_entrylog, readahead)
Changes
read_locations_index, read_entrylog, and readahead metrics types are adjusted from Counter to OpStatsLogger.
Adjustment before and after as follows
