Fix bug for short-to-int unary minus

Signed-off-by: Mihai Budiu <[email protected]>
apache · Nov 18, 2024 · 6ecf3a5 · 6ecf3a5
1 parent c71307d
commit 6ecf3a5
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/core/src/main/java/org/apache/calcite/runtime/SqlFunctions.java b/core/src/main/java/org/apache/calcite/runtime/SqlFunctions.java
@@ -2516,7 +2516,7 @@ public static byte checkedUnaryMinus(byte b) {
   }
 
   public static short checkedUnaryMinus(short b) {
-    return intToShort(b);
+    return intToShort(-b);
   }
 
   public static int checkedUnaryMinus(int b) {

diff --git a/core/src/test/resources/sql/cast.iq b/core/src/test/resources/sql/cast.iq
@@ -53,6 +53,10 @@ select -2147483648 / -1;
 Caused by: java.lang.ArithmeticException
 !error
 
+select -CAST(-32768 AS SMALLINT);
+Caused by: java.lang.ArithmeticException: integer overflow: Value 32768 does not fit in a SMALLINT
+!error
+
 select CAST(32767 AS SMALLINT) + CAST(2 AS SMALLINT);
 Caused by: java.lang.ArithmeticException: integer overflow: Value 32769 does not fit in a SMALLINT
 !error