[CALCITE-6693] Add Source SQL Dialect to RelToSqlConverterTest #4050
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please fix CLI |
hannerwang
force-pushed
the
null_collation_order_by_mismatch
branch
from
db271e5
to
2002efa
Compare
|
Thanks for the reminder, it's fixed. |
mihaibudiu
approved these changes
Nov 17, 2024
| @@ -559,7 +562,7 @@ private static String toSql(RelNode root, SqlDialect dialect, | |||
| + "FROM `foodmart`.`product`\n" | |||
| + "GROUP BY `product_class_id`, `product_id` WITH CUBE"; | |||
| sql(query).withHive().ok(expected); | |||
| SqlDialect sqlDialect = sql(query).withHive().dialect; | |||
| SqlDialect sqlDialect = sql(query).withHive().targetDialect; | |||
There was a problem hiding this comment.
I think this is a very useful change, the naming is indeed confusing.
mihaibudiu
added
the
LGTM-will-merge-soon
caicancai
approved these changes
Nov 18, 2024
|
-1 let's discuss in jira |
mihaibudiu
removed
the
LGTM-will-merge-soon
|
removed label until the discussion in JIRA is settled. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Add Source SQL Dialect to RelToSqlConverterTest to make dialect translation more clear.
Why are the changes needed?
Currently, RelToSqlConverterTest converts the original SQL to RelNode using the default validator config and the target dialect's type system, which is confusing. We should ensure the conversion conforms to the source dialect's specifications, and then convert from the source dialect's RelNode to the target dialect's SQL.
Does this PR introduce any user-facing change?
Yes, the null collation the PlannerImpl use will be validator config's null collation when calcite connection property unset.