Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skipped setup for camel-k using nexus deployment on ppc64le #5590

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Siddhesh-Prabhu
Copy link

For test TestMavenCASecret, as sonatype/nexus3:3.30.0 is not supported on ppc64le platform, need to skip the part of nexus deployment and use directly globally installed camel-k operator for integration.

Release Note

NONE

For test `TestMavenCASecret`, as `sonatype/nexus3:3.30.0` is not supported on ppc64le, need to skip this part and use directly globally installed camel-k operator for integration.
Copy link
Contributor

@squakez squakez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution, but I fear this can set a precedent. I understand there could be platform compatibility with architectures that third party tools (ie, sonatype) are not supporting. However, adding those skipping conditions is going to make the maintenance very hard.

If we're not able to support Nexus in a different architecture OOTB, maybe, it's time to rethink this test completely. It can be entirely moved to a unit test instead, where we want to check the configuration the operator produces is in line with what is expected.

90% of this test is the creation and the configuration of a Maven proxy. The only thing we verify on the operator is that no dependency is "Downloaded from central:".

This is the very same discussion I was having today on #5581 - we need to rethink or way of developing the project whenever we are facing these challenges.

@squakez
Copy link
Contributor

squakez commented Jun 5, 2024

If we still want to maintain the test, we can skip it entirely when the platform detected is different than the one expected, as we're doing for openshift. In such case we can introduce some environment variable to control the behavior.

@claudio4j claudio4j marked this pull request as draft July 2, 2024 17:30
Copy link
Contributor

This PR has been automatically marked as stale due to 90 days of inactivity.
It will be closed if no further activity occurs within 15 days.
If you think that’s incorrect or the issue should never stale, please simply write any comment.
Thanks for your contributions!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants