Allow to Cancel() query at any time #1174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
September 6, 2018 16:01
Solving apache#1173 * Add a Cancel() call to the RetryableQuery interface * Add cancelQuery and cancelBatch fields * Initiate Query/Batch context * Implement Cancel() call by calling the cancelQuery/cancelBatch functions * Add TestCancel to verify that the query is being cancelled by the cancel call before it's finished. Signed-off-by: Alex Lourie <[email protected]>
* The Cancel() call moved from RetryableQuery to ExecutableQuery * Simplify context and cancel functions initialisation * Improve TestCancel with the following: * the test is now actually testing that the query was cancelled. * doesn't need "veryslow" server query, just using "timeout" is enough * using a waitgroup to cleanup after the test * cut the runtime to about 20ms, so elapsed times measure is not required Signed-off-by: Alex Lourie <[email protected]>
|
This will be used in Speculative Query executions (#1083) to cancel the outstanding/other running queries when one has succeeded. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solving #1173
functions
cancel call before it's finished.