Doc: update the NOTICE and LICENSE files #812
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before donating Cloudberry to the Apache Incubator, we made some adjustments to LICENSE and NOTICE files, as reflected in the git blame history. However, those changes introduced unnecessary entries that didn't fully align with Apache guidelines. This commit refines these files to better comply with Apache standards and reflects the latest changes in the project source code. The COPYRIGHT file, inherited from the PostgreSQL upstream, served a similar purpose as the NOTICE file. As it is redundant, it has been removed from this commit.
tuhaihe
commented
Dec 24, 2024
Comment on lines
-3
to
-4
| Copyright (c) 2016-2023 HashData Technology Limited. or its affiliates. All | ||
| Rights Reserved. |
There was a problem hiding this comment.
As Cloudberry has been donated to ASF and the SGA has been signed, delete the HashData copyright notice directly here.
tuhaihe
requested review from
rvs,
WillemJiang,
edespino,
yaooqinn and
my-ship-it
|
Notes for your information:
|
|
Align the copyright description with the LICENSE and NOTICE.
They are used in codes too. |
avamingli
reviewed
Dec 24, 2024
Comment on lines
-697
to
710
| "Greenplum Database version of PostgreSQL Database Management System\n" | ||
| "Portions Copyright (c) 1996-2020, PostgreSQL Global Development Group\n\n" | ||
| "Portions Copyright (c) 2014-Present VMware, Inc. or its affiliates.\n\n" | ||
| "Portions Copyright (c) 2011-2014 EMC\n\n" | ||
| "Apache Cloudberry (Incubating)\n" | ||
| "Copyright 2024 The Apache Software Foundation\n\n" | ||
| "This product includes software developed at\n" | ||
| "The Apache Software Foundation (http://www.apache.org/).\n\n" | ||
| "This product contains significant parts that were originally based on software\n" | ||
| "from VMware, Inc. or its affiliates. (Greenplum Database<https://www.greenplum.org/>).\n" | ||
| "Copyright (c) 2004-2020 VMware, Inc. or its affiliates.\n" | ||
| "License under the Apache License 2.0.\n\n" | ||
| "This product contains significant parts that were orginally based on software\n | ||
| "from PostgreSQL Global Development Group (PostgreSQL 14.4 <https://www.postgresql.org/>).\n" | ||
| "Portions Copyright (c) 1996-2022, PostgreSQL Global Development Group\n" | ||
| "Portions Copyright (c) 1994, The Regents of the University of California\n" | ||
| "License under the PostgreSQL License.\n\n" | ||
| "This software is based on Postgres95, formerly known as Postgres, which\n" | ||
| "contains the following notice:\n\n" | ||
| "Portions Copyright (c) 1994, The Regents of the University of California\n\n" | ||
| "Permission to use, copy, modify, and distribute this software and its\n" |
|
If you make any modifications to the C code, it's important to note that you typically cannot use the "skip CI" flag. Even small changes, like adjustments to the output text, may result in regression differences. |
Ok. I want to confirm that if these three project codes are included in the repo, or just link them dynamically? |
yes, correct. Will remove the tag to trigger the CI again. |
tuhaihe
changed the title
tuhaihe
removed request for
rvs,
WillemJiang,
edespino,
yaooqinn and
my-ship-it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #ISSUE_Number
What does this PR do?
Before donating Cloudberry to the Apache Incubator, we made some adjustments to LICENSE and NOTICE files, as reflected in the git blame history. However, those changes introduced unnecessary entries that didn't fully align with Apache guidelines. This commit refines these files to better comply with Apache standards and reflects the latest changes in the project source code.
The COPYRIGHT file, inherited from the PostgreSQL upstream, served a similar purpose as the NOTICE file. As it is redundant, it has been removed from this commit.
Type of Change
Breaking Changes
Test Plan
make installcheckmake -C src/test installcheck-cbdb-parallelImpact
Performance:
User-facing changes:
Dependencies:
Checklist
Additional Context
CI Skip Instructions