Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dependabot: ignore dep versions that require Java 11 #473

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

dependabot: ignore dep versions that require Java 11 #473

wants to merge 1 commit into from

Conversation

raboof
Copy link
Member

@raboof raboof commented Jan 24, 2025

Replaces:

  • Read the contribution guidelines for this project.
  • Run a successful build using the default Maven goal with mvn; that's mvn on the command line by itself.
  • Write unit tests that match behavioral changes, where the tests fail if the changes to the runtime are not applied. This may not always be possible but is a best-practice.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Each commit in the pull request should have a meaningful subject line and body. Note that commits might be squashed by a maintainer on merge.

ppkarwasz
ppkarwasz reviewed Jan 24, 2025
View reviewed changes
.github/dependabot.yml
Comment on lines +24 to +27
- dependency-name: org.jboss.narayana.jta:narayana-jta
versions:
# require Java 11
- ">= 5.13.0"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have never seem this syntax for Maven deps, are you sure it works?

Copy link
Member Author

@raboof raboof Jan 24, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've seen it in a bunch of places (https://github.com/apache/avro/blob/main/.github/dependabot.yml#L34, https://github.com/apache/maven-artifact-transfer/blob/mvn4/.github/dependabot.yml#L27, https://github.com/apache/maven-dependency-plugin/blob/master/.github/dependabot.yml#L26, https://github.com/apache/maven-dependency-tree/blob/master/.github/dependabot.yml#L26) but haven't tested it directly

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, let's merge this one then and see how it works in practice.
If it works Dependabot should close the PRs you mention at the beginning.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ppkarwasz ppkarwasz ppkarwasz left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@raboof @ppkarwasz