Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optionally force UTF-8 encoding for IPTC records #477

Merged

Conversation

thstieler
Copy link
Contributor

This pull request adds the option to enforce UTF-8 encoding for writing IPTC records to jpeg files.

This can improve the reliability for correct parsing of IPTC records written by commons-imaging, because some libraries/applications use UTF-8 as default charset when reading IPTC records.

@garydgregory
Copy link
Member

@thstieler

It looks like you did not follow the PR template, specfically:

  • Run a successful build using the default Maven goal with mvn; that's mvn on the command line by itself.

@thstieler
Copy link
Contributor Author

@garydgregory You're right, unfortunately I forgot to remove trailing whitespace in one line, now mvn completes successfully!

@garydgregory garydgregory merged commit 568e3f6 into apache:master Jan 21, 2025
@garydgregory
Copy link
Member

@thstieler
Thank you for the update, merged! 🚀

@thstieler
Copy link
Contributor Author

@garydgregory Thank you very much, that's great :-)!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants